[Libreoffice] [PATCH] Fix for fdo43460, Part I, getLength to isEmpty

Olivier Hallot olivier.hallot at documentfoundation.org
Fri Dec 9 10:15:29 PST 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

ooops... silly me....

thanks

Em 09-12-2011 16:07, Stephan Bergmann escreveu:
> On 12/09/2011 05:14 PM, Olivier Hallot wrote:
>> diff --git a/accessibility/source/standard/vclxaccessiblebox.cxx
>> b/accessibility/source/standard/vclxaccessiblebox.cxx
>> index e868403..82a7677 100644
>> --- a/accessibility/source/standard/vclxaccessiblebox.cxx
>> +++ b/accessibility/source/standard/vclxaccessiblebox.cxx
>> @@ -156,7 +156,7 @@ void VCLXAccessibleBox::ProcessWindowEvent (const
>> VclWindowEvent& rVclWindowEven
>>                  if ( xText.is() )
>>                  {
>>                      ::rtl::OUString sText = xText->getSelectedText();
>> -                    if ( !sText.getLength() )
>> +                    if ( !sText.isEmpty() )
>>                          sText = xText->getText();
>>                      pList->UpdateSelection (sText);
>>                  }
> 
> This and a few more that follow invert the logic -- !sText.getLength()
> <=> sText.getLength() == 0 <=> sText.isEmpty().  I'll fix those and push
> later today.
> 
> Thanks a lot,
> Stephan
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJO4lBBAAoJEJp3R7nH3vLxrnsH/2xbSxmaNCe6Xu7swN/wLG+x
5EByvDnDo9nOdbTH/UwDrK/ZpNmEulbtU+qsu4RdVIefFWJiv7y77ddVzTIofOhw
xKkg6Im/A6V/ECJbdDNBQojV0zdLmAN5EYdjzIg99vEVppb9irbchuV1c7Iu/hDF
snacl6IeItfV+LDGbaOVPbpARHo2Qp4BPRvD7I/riVLbEsJIPwZnHHH38k/PElSy
IAoNibf5oc9MzSnib6i+37pFlcSoF96b75LnOpo3srB76Oi1aA/t3CNjEc0D7m7w
ikhZHpns/vIKa3SGEznT0xootv8cJTzOR+VuRBLYLyYtXnyVTJvDvKZnpDZmY10=
=rkYL
-----END PGP SIGNATURE-----


More information about the LibreOffice mailing list