[Libreoffice] [REVIEWED][PUSHED:3-4] Fix overly zealous check in Zip package consistency

Petr Mladek pmladek at suse.cz
Wed Dec 14 06:38:45 PST 2011


Michael Meeks píše v St 14. 12. 2011 v 14:10 +0000:
> On Wed, 2011-12-14 at 14:42 +0100, Thorsten Behrens wrote:
> > Michael Meeks wrote:
> > > 	I'd be happier to see the nMethod being compared if we had removed the
> > > comment, and/or at least understood whether it is still relevant: are we
> > > using/changing nMethod elsewhere ?
> >
> > Yep, good point. Tweaked for master. That comment looks false, did
> > not find any place where that would be used - also, FWICT, it would
> > not comply with the zip appnote...
> 
> 	Great; I did the same git grep and it seems it's only fiddle with on
> writing so we should get it in :-)

Thanks for review. I have pushed it into libreoffice-3-4 branch. It will
be in 3.4.5-rc1.


Best Regards,
Petr



More information about the LibreOffice mailing list