[Libreoffice] [REVIEW] Re: SmNodeToTextVisitor Fixes

[Jonas Finnemann Jensen]

Hi,

Sorry, I'm so slow to reply... School is keeping me busy...

Anyway, the patch looks fine...

I've pushed your patch for libreoffice-3-3

Great... - again sorry I'm so slow...

If we get another review of the patch, we could put it
> into libreoffice-3-3-1

If there both a libreoffice-3-3 and libreoffice-3-3-1, and think it's fine
to push it to both...

--
Regards Jonas Finnemann Jensen.


On Thu, Feb 10, 2011 at 14:08, Michael Meeks <michael.meeks at novell.com>wrote:

> Hi Luke,
>
> On Tue, 2011-02-08 at 20:50 +0000, Luke Dixon wrote:
> > I guess I'm too late now, so maybe for 3.3.2, but maybe there are a
> > couple of bugs that could be fixed for libreoffice-3-3.
>
>         I've pushed your patch for libreoffice-3-3 - but really, with you
> and
> Jonas' review you could have done that yourself.
>
> > We could fix two of the bugs, 32759 and 32755 on the freedesktop.org
> > bugzilla, as they are quite simple and seem to be a fixable by removing
> > one character and one line (which is how it is now on master now). It
> > seems so simple I wonder if I'm missing something about these two?
>
>         :-)
>
>        If we get another review of the patch, we could put it into
> libreoffice-3-3-1 I suppose; Caolan might be interested.
>
> commit 60c297cc61df9ef025312f75ba214b4a8499e959
> Author: Luke Dixon <6b8b4567 at gmail.com>
> Date:   Tue Feb 8 20:15:21 2011 +0000
>
>    Fix for bugs 32759 and 32755 on freedesktop bugzilla
>
>        in writer/ on libreoffice-3-3.
>
>        I'll close the bugs.
>
>        ATB,
>
>                Michael.
>
> --
>  michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot
>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110210/adacf7cc/attachment.html>