[Libreoffice] [PATCH] Some build breakage fixes for MSVC2008

Steven Butler sebutler at gmail.com
Sat Feb 12 02:54:50 PST 2011


Hi all,

I was finally able to get a successful build and package to complete
on Windows using MSVC2008 Express.

I was not able to do this on my windows 7 64 bit machine but this may
be due to the diversity of development environments I had previously
installed on it.

I worked around the problem by using a Windows XP Mode VM to do a
fresh install of the tool chain.

I had to make the following small patches to get the build to work.

sw_compile.patch does a nasty hack to make a member function mutable
because it is referenced all over the place using non const iterators.

I didn't want to break anything so I took an easy out and made it
mutable but I would think it would be better fixed by using const_cast
wherever a non-const iterator is created.

sw_const_fix.patch addresses a couple of const_iterator issues in unochart.cxx.

unopkg_app_stl_fix.patch fixes apparent breakage in the use of fill_n
- my reference says it returns void but the original code was
expecting an iterator returned.  I imagine it must be an STLport
extension, but it is broken with the built in STL and I believe the
fix is correct.

Regards
Steven Butler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sw_compile.patch
Type: application/octet-stream
Size: 849 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110212/82aa81aa/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sw_const_fix.patch
Type: application/octet-stream
Size: 2055 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110212/82aa81aa/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unopkg_app_stl_fix.patch
Type: application/octet-stream
Size: 1300 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110212/82aa81aa/attachment-0002.obj>


More information about the LibreOffice mailing list