[Libreoffice] [PUSHED] Re: [PATCH] O(U)StringBuffer::toString()

[Caolán McNamara]

On Sat, 2011-02-12 at 14:52 +0100, Sébastien Le Ray wrote:
> Hi list,
> 
> Since the toString() method is mentioned in the O*StringBuffer
> documentation I thought it was a good idea to actually have it...

Yeah, especially handy because makeStringAndClear destroys the old
contents, which makes it kind of painful to debug its contents when you
just want a quick and dirty printf.

> Patch is splitted in two parts. First adds the toString() methods and
> second perform some cleanup in OUStringBuffer unit tests (see commit
> message for details).

Looks most excellent, all pushed. Thanks for this.

Note, doesn't affect our ABI seeing no extra symbols actually get
exported.

As an aside, if you're big into the sal unit tests there's probably
quite a few of them potentially useful which haven't been tweaked to
work again, or are behind SUBSEQUENT_TESTS but probably don't need to be
inside that conditional, i.e. they would work in a build-from-scratch
state.

C.