[Libreoffice] Undo Redo Re: [REVIEW] Re: SmNodeToTextVisitor Fixes

[Jonas Finnemann Jensen]

Hi Luke,

Here's the redo of this patch :)

Cool, pushed... :)
This is a nice step towards getting it stable... If you like searching code
and guessing what might be the right solution, copy/paste integration could
be next...


By the way, let me know if you've any ideas on how formatting should work,
without rewriting the node structure, an run into a problem with maintaining
the command text language...

--
Regards Jonas Finnemann Jensen.


On Wed, Feb 16, 2011 at 00:16, Luke Dixon <6b8b4567 at gmail.com> wrote:

> Hi Jonas,
>
> On Tue, 2011-02-15 at 21:51 +0100, Jonas Finnemann Jensen wrote:
>
> > Well, lets just think about writing a note for the next guy, if we
> > find a solution :)
>
> I suppose the EditEngine::SetText functions would be be a good place to
> start.
>
> >
> > I noticed that 0xFFFF is used in SelectAll... but searching for
> > EE_PARA_ALL, gives some results where it's used for creating
> > selections, so that's probably what it's a constant for...
>
> It's a small matter, but not sure it is quite right as the 4th argument
> but at least there is other code that can be pointed at which does this.
>
> >
> > Unless, you've other ideas, I suggest don't you update your patch,
> > then I'll push it... And please update the todo-list, you've just
> > fixed one of the complicated issues... :)
>
> Here's the redo of this patch :)
>
> Thanks for all your help :) might not have got there otherwise. Let's
> hope it will be okay.
>
> Regards,
> Luke
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110216/78392bbb/attachment.htm>