[Libreoffice] [PATCH] Remove "using namespace ::rtl" in sc

Bjoern Michaelsen bjoern.michaelsen at canonical.com
Thu Feb 24 07:45:05 PST 2011


Hi, 

On Thu, 24 Feb 2011 15:30:45 +0000
Caolán McNamara <caolanm at redhat.com> wrote:

> On Thu, 2011-02-24 at 10:11 -0500, Kohei Yoshida wrote:
> > On Thu, 2011-02-24 at 15:26 +0100, Julien Nabet wrote:
> > > 2) must we remove all the "rtl::" stuff ?

> -using namespace rtl;
> which looks fine,
+1 

> +using ::rtl::OUString 
> which looks fine when necessary to make it possible to compile a file
> which used to have "using namespace rtl;"
+1

> -rtl::OUString
> +OUString
> which would be unnecessary, and likely cause a huge amount of churn,
> no ?
Right. Those should be left as is, as being a little more explicit does
not hurt, esp. since it does not impact readability.

Best Regards,

Bjoern

-- 
https://launchpad.net/~bjoern-michaelsen




More information about the LibreOffice mailing list