[Libreoffice] [PATCH] set the icons size based on the DPI just like we do on Mac

Michael Meeks michael.meeks at novell.com
Wed Jan 5 09:14:02 PST 2011


Hi Robert,

On Wed, 2011-01-05 at 16:24 +0100, Robert Nagy wrote:
> On (2011-01-05 14:27), Michael Meeks wrote:
> > 	So - I would prefer to stick with large icons; and not use the DPI
> > setting. I suggest instead, that we only use large icons if the true Y
> > resolution > 768 - how does that sound ?
> 
> Oh wait, I misunderstood. That is wrong. I am on a 1920x1080 display

	:-) so - as I say; the DPI is a constant of 75 across the Linux
desktop, so this is not a switch but a hard coded setting :-)

	I am still convinced that large icons, on a reasonably sized screen
give a -far- more useful view of the metaphore for a beginner user. As I
say, advanced users can make it smaller.

> and i still prefer the small icons, it is like that in _every_ app. So
> we should stick to the DPI.

	Well; looking at gedit - it is using gtktoolbar.c's:

#define DEFAULT_ICON_SIZE GTK_ICON_SIZE_LARGE_TOOLBAR

	ie. the same size (large) icons that we are using here. Perhaps the
size setting is coming from the theme, in which case we should extract
it and use exactly that setting in LibreOffice - can you have a dig ?
(can you check that stock gtk+ apps do indeed have small toolbar
icons ?).

	Thanks,

		Michael.

-- 
 michael.meeks at novell.com  <><, Pseudo Engineer, itinerant idiot




More information about the LibreOffice mailing list