[Libreoffice] [PATCH] Moving misplaced Compatibility options from ScDocOptions to ScAppOptions

[Markus Mohrhard]

Hello Albert,

nice work but I have some comments.

Operator== should have return type bool and not int(I saw that ScDocOptions
used int too, but I have changed that already).
But all in all I think we shouldn't introduce operator== there.
I didn't like the old approach with operator== but after your changes it
seems even more unnecessary. Let's just use ScAppOptions directly and set
the keybinding even if it is the same keybinding as the old one. With this
approach you don't need to compare two ScAppOptions instances and there is
no need for operator== anymore. And all in all I think we can remove the two
dynamically created ScAppOption instances with this approach.

If you need some more information or advise, feel free to ask.

Regards,
Markus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110712/a408c870/attachment.html>