[Libreoffice] [PATCH] Work around a bash-ism in configure.in

Christian Lohmaier lohmaier+libreoffice at googlemail.com
Mon Jul 18 04:56:39 PDT 2011


Hi MIke, *,

On Fri, Jul 15, 2011 at 9:34 PM, Mike Eberdt <libreme at comcast.net> wrote:
>
> Configure.in eventually gets parsed by /bin/sh, and on Free/Net/OpenBSD
> /bin/sh is not synonymous with bash.  Therefore, bash-isms in configure.in
> can be problematic.

I don't understand your patch then.
-if test "$EUID" -eq "0"  -a "z`uname -o 2>/dev/null`" = "zCygwin" ; then
+# $EUID is a bash-ism, so we can't assume its existence.
[...]
+if test "z`uname -o 2>/dev/null`" = "zCygwin" && test "$EUID" -eq 0; then

So while you converted test "and" link to &&, the $EUID that according
to your comment is a bashism still is used. So how does this solve
anything?

(Besides that, configure is created with shebang of /bin/bash here)

ciao
Christian


More information about the LibreOffice mailing list