[Libreoffice] [REVIEW] fix for fdo#37628: pssword button is always disabled

Markus Mohrhard markus.mohrhard at googlemail.com
Sun Jul 24 11:22:01 PDT 2011


Hello Kohei, all,

this is a possible patch for the problem that the button at File->Properties
is always disabled even if you have a password protected file.

The problem was that SID_PASSWORD, which saved the plain text password, is
no longer used but we use SID_ENCRYPTIONDATA which saves the hash. I changed
the code for this button so that it shares the implementation with the file
save dialog.

I haven't found a nice place for the method RequestPassword so I have
decided to leave it in filedlghelper.[ch]xx . I'm open for any suggestions
where this method should be located. This patch applies to 3.4, I haven't
tested yet with master since master has several code changes in the password
related code.

Regards,
Markus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110724/98ab7a4b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-for-fdo-37628-change-password-button-is-always-d.patch
Type: text/x-patch
Size: 13058 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110724/98ab7a4b/attachment-0001.bin>


More information about the LibreOffice mailing list