[Libreoffice] [review for 3.4] fix for bnc#707486

[Noel Power]

Hi Kohei

On 28/07/11 17:48, Kohei Yoshida wrote:
> Hi Noel, 
[...]
> where these lines ScUnoConversion::FillScRange( aRange, 
> thisRange.getCellRangeAddressable()->getRangeAddress() ); 
> uno::Reference< frame::XModel > xModel = excel::GetModelFromRange( 
> mxRange );and the line are flipped before and after in the 'else' 
> scope. Unless that's intentional, I would flip these lines back to 
> match the original code. Let me know what you think of this, and I'll 
> then push to the 3-4 branch with the above lines flipped back. 
If I understand what you mean then I think it is the patch output is 
confusing things, what has happened is the logic has changed from ( in 
psuedo code )

     if ( isMultiAreaRange() )
         get out of here

     if ( destination is specified )
        do stuff
     else
        process single range

to....


     if ( destination is specified )
        do stuff
     else
        if ( isMultiAreaRange() )
            process multiAreaRange
        else
            process single range

and I think you are referring to the apparent 'flipping' of the 'process 
single range' code right? if so this is intentional ( but you had me 
worried :-))) )

but one thing that I didn't think of ( 'till you made me look closer ) 
was the handling of the 'if ( destination is specified )' leg and that I 
think I need to modify to be ( to avoid a possible core dump ) - will 
attach newer patch for that

     if ( destination is specified )
         if ( isMultiAreaRange )
             get out of here
         do stuff
thanks

Noel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 707486-3.4.diff
Type: text/x-patch
Size: 12064 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110729/497a5408/attachment-0001.bin>