[Libreoffice] [REVIEW] fix for fdo38204: formulas with range names were not imported correctly from xls

Noel Power nopower at novell.com
Thu Jun 23 01:27:41 PDT 2011


On 22/06/11 19:44, Markus Mohrhard wrote:
> Hello all,
>
> I have a new patch for another problem around range names. We couldn't 
> import formulas with range names from xls due to a false check.
> The named range index is 1-based during import and so the check is 
> only allowed to check for > but not >=.
>
> I think we should include this patch into 3-4 because it is a serious 
> problem if all formulas with range names are screwed up.
>
> Regards,
> Markus
looks good to me, please commit to master, let me know the commit id and 
I will cherrypick/signoff for 3.4
thanks again for another great catch

Noel


More information about the LibreOffice mailing list