[Libreoffice] [PATCH] Removed never defined _OLD_FILE_IMPL

Noel Power nopower at novell.com
Tue Mar 22 02:40:55 PDT 2011


Hi Christina
On 21/03/11 22:28, Christina Roßmanith wrote:
> nd calls nothing that does that ?
> As far as I understand the code it consists merely of test calls to 
> functions in order to see if they return a valid result. I'm quite 
> sure that you already know whether it has side effects or not... I 
> vote for "it hasn't", but I'm absolutely not sure
nah, just seems like some testing to see if uno is bootstrapped and the 
ucp stuff available, it looks to me especially in the case you removed 
to be completely useless.
Btw if you are feeling frisky and wish to kill other related pieces of 
uselessness :-) there are the  #ifdef _USE_UNO associated blocks  that 
you can see around the hasUno() method ( and others ) that need some 
removing ( afaics _USE_UNO is defined always )


Noel


More information about the LibreOffice mailing list