[Libreoffice] [PATCH] Easy hacks: Remove misuse of SfxItemSet API from libs-core

Theo van Klaveren theo.van.klaveren at gmail.com
Mon Mar 28 02:25:32 PDT 2011

Hello everyone,

I've started work on removing all calls to SfxItemSet::Put(SfxPoolItem &,
int which) from the code. Attached the first two patches,
which contains mostly easy cases: Almost all SfxPoolItems already contained
the right WhichID, so the extra argument could
just be removed. But there are some slightly more interesting cases in here
as well.

I have more patches ready to go, but I'd like to get these reviewed first to
check I'm on the right path. The really hard cases are
in other parts of the code :)

As always, contributed under LGPLv3+/MPL dual license.

Kind regards,
 - Theo van Klaveren
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110328/a29200c6/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-misuse-of-SfxItemSet-API-from-editeng.patch
Type: text/x-patch
Size: 4583 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110328/a29200c6/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Remove-misuse-of-SfxItemSet-API-from-svx.patch
Type: text/x-patch
Size: 4948 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110328/a29200c6/attachment-0003.bin>

More information about the LibreOffice mailing list