[Libreoffice] [REVIEW] fix for fdo#41807 crash with ROW() or COLUMN() in matrix formulas

[Eike Rathke]

Hi Markus,

On Tuesday, 2011-11-01 22:45:57 +0100, Markus Mohrhard wrote:

> http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf0dd2113527ba0a601c5c59de7f7f44da161d21

Taking a second look, that patch would break handling of the case when
the matrix is a valid 2D matrix with more than one column and more than
one row. See implementation of ValidColRowReplicated(), which is not
meant to be used in such a context, but to determine whether a col/row
needs to be replicated in case the matrix is only a vector. If at all,
the intended behavior could be realized using ValidColRowOrReplicated()
instead, however, I currently don't remember why all Is*() methods don't
use it whereas all Get*() methods do.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111102/db8ca24b/attachment-0001.pgp>