[Libreoffice] [PUSHED][PATCH] Re: Easy hack regex compile infinite loop ( bug 41738 )

[Noel Grandin]

Seems like this is a case where you should be able to find unit
testing in some other open source project, rather than writing them
from scratch.
Mozilla, Apache Harmony, Perl, Webkit, Python, should all have a bunch
of unit testing code for their regular expression features.

In fact, there are a couple of open-source libraries for regex stuff,
I'm sure it would better to simply use the code of one of those other
projects, rather than maintaining our own.
Webkit/Mozilla should have excellent engines inside their JavaScript
modules written in C++ that we could copy.
And they would have seen an enormous amount of testing.

Regards, Noel Grandin


On Fri, Nov 11, 2011 at 18:48,  <koehlerkarl at comcast.net> wrote:
> Hi Eike,
>
> I confirm I contribute this and all future patches for LibreOffice under the LGPLv3+ and MPL 1.1 .
>
>> Yes, there are quite some shortcomings and bugs with that code.
>> I wouldn't invest too much time though, plan is to replace that legacy
>> code entirely with the more suitable ICU regex.
>
> This seems like a nice idea .. is there already a bug/Easy hack for that ?
>
> Thanks !
>
>  - Karl
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>