[Libreoffice] [PATCH] Fix bug in build.pl option parser

[Daisuke Nishino]

Hi all,

I'm not much familiar with perl, but I think the previous implementation of
build.pl had bugs.
For example, --skip option would always be rejected before 'next'
statement, because get_modules_passed() always returns nothing (evaluated
as false). As a result --skip would be incorrectly pushed to @dmake_args.
The same is true for other options, when rhs of assignment is something
evaluated as false (including "0" and '').

I also think it is not good behaviour to push options to @dmake_args when
it fails to parse.
However, I didn't fix it because that could possibly introduce incosistency
with existing scripts.

Cheers,

-- 
Daisuke Nishino
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111113/6528d03e/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-bug-in-build.pl-option-parser.core.patch
Type: application/octet-stream
Size: 7484 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111113/6528d03e/attachment.obj>