[Libreoffice] [PATCH] Docuview code cleanup

Matteo Casalin matteo.casalin at poste.it
Sun Nov 13 10:54:46 PST 2011


Hi everybody,
     my name's Matteo and this is my first contribution [attempt] to 
this wonderful piece of work, besides "spreading the word".
The attached patch does a little code cleanup in Docuview::DrawSymbol 
function and its helper, reducing local variables and calls to "real" 
draw functions.
Please note that:
* the results of reworked code was not fully tested, since I really
   don't know were all of those symbols are drawn, but those that I was
   able to verify look OK to me;
* There were some inconsistencies in symbol size evaluation, I chose
   one approach but it could be not the best or correct one;
* There are still other cleanups that can be done in that code, but I
   would like to have some feedback before working on them. For example,
   this patch could include too many changes.
The attached patch is contributed under LGPL3+/MPL1.1 license.

Ciao
Matteo


More information about the LibreOffice mailing list