[Libreoffice] [PUSHED] [PATCH] Part of FDO #42454 - Remove code associated with unused icons

Julien Chaffraix julien.chaffraix at gmail.com
Tue Nov 15 07:16:31 PST 2011


> some physical images removed here are
> lx03139.png
> sx03139.png
> oth_16_8.png
> oth_32_8.png
> oth_48_8.png
>
> these images are associated with SV_ICON_ID_HTML_DOCUMENT which according to
> opengrok ( assuming it is correct ) isn't used in code.
>
> however there are still entries for these in images.src and ditto svids.hrc
>
> ok, I have removed these in an additional commit and hope I did the right
> thing

I think your change was a mistake: SV_ICON_ID_HTML_DOCUMENT is used
but never mentioned. I fell into the same pitfall while removing the
images. The patch AS-IS was compiling on linux AFAICT.

Btw, do you have the error message from the tinderbox by any chance as
it would be useful to know what was missed here?

Thanks,
Julien


More information about the LibreOffice mailing list