[Libreoffice] [PUSHED] [PATCH] Fix Kashida justification when there is no Kashida glyph

[Khaled Hosny]

Hi Thorsten,

On Mon, Nov 28, 2011 at 11:57:04AM +0100, Thorsten Behrens wrote:
> Khaled Hosny wrote:
> > This patch removes the "reasonable default" value of mnMinKashida which
> > makes no sense at all; either the font have a Kashida glyph and
> > mnMinKashida is set to its width or it doesn't and mnMinKashida is kept
> > 0.
> > 
> Hi Khaled,
> 
> nice one, pushed - by any chance, do you have a small test document
> that demonstrates the problem, e.g. with a common font that lacks
> kashida support? Such that going forward, we don't break this again.

It is really an edge case and I don't think there are fonts with Arabic
coverage lacking Kashida, however I'm developing a font where I trick
LibreOffice not to do Kashida justification by having a zero width
Kashida glyphs (The font is pretty complex with many contextual forms
and Kashida justification as implemented in LibreOffice, or other
application for that matter, is guaranteed to always produce bad
result). Anyway, the font can be obtained from here[1], and I'm
attaching a test file that shows this issue.

[1] https://sourceforge.net/projects/amiri/files/

Regards,
 Khaled
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lo_no_kashida.odt
Type: application/vnd.oasis.opendocument.text
Size: 10775 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111128/36672ec1/attachment-0001.odt>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3.4.png
Type: image/png
Size: 13711 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111128/36672ec1/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 3.5_patch.png
Type: image/png
Size: 12868 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111128/36672ec1/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20111128/36672ec1/attachment-0001.pgp>