[Libreoffice] [PATCH] Fix rendering of GTK combobox in RTL

Khaled Hosny khaledhosny at eglug.org
Tue Nov 29 23:11:14 PST 2011


Hi all,

Here is a little patch that fixes a rendering buglet that annoyed me
since ever. Native GTK applications swap the position of the button and
editing area of comboboxes in RTL and themese expect that, but LO does
not.

The same issue happens with spin buttons and other similar widget, I'm
just making sure I'm doing it right before sending other patches.

Also I'm not sure how GTK3 relates to this (is it affected/need to be
fixed separately etc.) since I can't build with it here.

BTW, Application::GetSettings().GetLayoutRTL() is now used in several
places (and may be more will come), would it be more rideable/save a few
microsocends to have a 

bool isLayoutRTL = Application::GetSettings().GetLayoutRTL()

(or something like that) on the top of the file?

Regards,
 Khaled


More information about the LibreOffice mailing list