[Libreoffice] [PATCH] Replace WW8Bytes with ww::bytes

[Maciej Rumianowski]

Dnia 2011-10-05, śro o godzinie 17:35 +0200, Lubos Lunak pisze:
> On Wednesday 05 of October 2011, Jan Holesovsky wrote:
> > Hi Maciej,
> >
> > On 2011-10-05 at 10:39 +0200, Maciej Rumianowski wrote:
> > > There was a lot of WW8Bytes( SV_DECL_VARARR ) which was partly replaced
> > > with ww::bytes. This set of patches totally migrates code to ww::bytes.
> >
> > Very nice, thank you! :-)
> >
> > Before pushing, I wonder - ww::bytes is std::vector<sal_uInt8>; is there
> > a reason not to make it std::basic_string<sal_uInt8> instead?
> 
>  How about the fact that ww:bytes is not, in fact, a string? At least as far 
> as I can see.
So I did not investigate this, but ww::bytes as vector was there before and some methods were prepared already for migration.
I agree that basic_string is strange there.
> > That would allow you to convert the pO->GetData() to something like
> > po->data(), instead of &(*pO)[0] (and similar) used on many places...
> 
>  That same would be allowed by 
> class bytes : public std::vector<sal_uInt8>
> {
> public:
> const sal_uInt8* data() const { return &front(); }
> ...
So if it is desired solution I can modify Patches?

Cheers,
	Maciej