[Libreoffice] [PUSHED] [REVIEW] patch for fdo38286 EDITING: Crash when inserting a constant in a query

Petr Mladek pmladek at suse.cz
Mon Oct 24 07:21:33 PDT 2011

julien2412 píše v So 22. 10. 2011 v 02:33 -0700:
> I commited (48cdc0318b348c51742339b243dc05546148b335) and pushed on Master
> the patch by adding a comment too. 
> I put the fdo bug to "resolved".
> I let you see about 3.4 since it needs review.

The check for "pNode->count()" makes perfect sense. I am not 100% sure
that the fallback "pFunctionName = pNode;" is correct. Well, it should
not be worse than the crash.

The patch really fixes the crash and works reasonable, so I have pushed
it for libreoffice-3-4, see

Thanks a log for working on these nasty bugs.

Best Regards,

More information about the LibreOffice mailing list