[Libreoffice] [PUSHED][PATCH] warining elimination

Caolán McNamara caolanm at redhat.com
Thu Sep 1 08:23:46 PDT 2011


On Thu, 2011-09-01 at 15:34 +0200, Jenei Gábor wrote:
> Hello,
> 
> Here is a patch to avoid compile time warnings

Looks fine, we get screwed a bit because sal_Int32 is an "int" on x86_64
and "long" on x86 which triggers some of these. And they're inside debug
mode I think in this case.

The alternative fix for some of them, though probably overkill for debug
stuff is the SAL_PRIdINT32, SAL_PRIuUINT32, SAL_PRIxUINT32 and
SAL_PRIXUINT32 set of stuff.

I pushed this, but some conflicts from changes in between, I just
dropped the conflicting bits.

> OpenSSL, could you tell me why are these libraries compiled? On most
> of the linux machines it should be already installed, aren't compiled
> shared libraries enough

IIRC, correct me if I'm wrong, the soname of openssl changes a bit so
stuff linked against one doesn't resolve against another, even if we
linked the universal build against an old one. Possibly reworking the
bits that require openssl to use nss and/or linking statically might
make some of that go away.

C.



More information about the LibreOffice mailing list