[Libreoffice] cppcheck duplicate if expressions in bulmaper.cxx (sd part)

Caolán McNamara caolanm at redhat.com
Fri Sep 9 04:10:52 PDT 2011


On Fri, 2011-09-09 at 08:19 +0200, Stephan Bergmann wrote:
> On 09/08/2011 10:47 PM, julien2412 wrote:
> > I checked the history, it's there since 16/11/2000 (commit
> > 5dc708093d1ee179099abdcbf0c6f649b1c4deeb)
> >
> > could anyone explain to me the purpose of this ? Just a typo ?
> 
> It's preceded by comment "to be implemented if module supports CJK" a 
> few lines above at sd/source/ui/func/bulmaper.cxx:73, so I would say its 
> something like commented-out code that still awaits implementation...

At this point with 11 years as a to-do I suggest you ditch the if'0ed
out code and comment.

C.



More information about the LibreOffice mailing list