[Libreoffice] [patch] memset used on struc with std::vector / Windows code

Eike Rathke ooo at erack.de
Sun Sep 11 06:48:12 PDT 2011

Hi Pierre-André,

On Sunday, 2011-09-11 14:20:57 +0200, Pierre-André Jacquod wrote:

> the struct DdeInstData contains a std::vector, but was initialized
> with memset( pData,0,sizeof(DdeInstData) )

Good catch.

> So I tried to have a consistent initialization with the new struct layout.

That should happen in a DdeInstData ctor instead. Note that you don't
need to explicitly clear the vector on that newly allocated object, it
is created empty anyway.


 PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
 Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110911/8afcc88d/attachment-0001.pgp>

More information about the LibreOffice mailing list