[Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391
caolanm at redhat.com
Tue Sep 20 03:04:08 PDT 2011
On Sat, 2011-09-17 at 03:33 -0700, Ivan Timofeev wrote:
> This patch fixes crash when you input incorrect range of pages in "Print"
> dialog, "General" tab, "Pages" textfield and layout is set to "Brochure".
Ah, indeed. That's a great catch. The earlier page count is more
tolerant of incorrect ranges, while the specific get the exact pages to
print is more strict, so it blows up and dies.
I don't *think* we need to move the code around, the check for empty is
sufficient so I shrank it down to that bit.
I think this is really worth cherry-picking to 3-4, i.e.
More information about the LibreOffice