[Libreoffice] [REVIEW 3-4] fdo#39510 crash on closing document with footnotes
nospamformba at gmx.de
Fri Sep 23 14:53:19 PDT 2011
Am 22.09.2011 19:12, schrieb Michael Stahl:
> On 22.09.2011 18:51, Bjoern Michaelsen wrote:
>> Hi Cedric, Hi Caolan,
>> could you please review:
>> for backporting to -3-4? It kills the footnotes before killing the rest
>> of the layout saving us from the trouble later. It seems to fix the
>> problem with the test document here and also that fix passes all
>> unittests and subequenttests on master.
> is this the kind of crash that was introduced by mba's layout refactoring
> (moving the layout from the model to the view) that went into one of the
> last DEV300 milestones?
That's indeed possible.
> i think the workaround for OOo 3.4 was this:
> wonder what Oliver and Mathias had in mind as the proper fix...
The idea was to add a new method "IsInDtor" to the layout and use this
instead of the method of SwDoc where appropriate.
The *real* fix would be fixing the layout mess so that it does not crash
when a layout of a certain complexity is destroyed. But most probably
that come close to a rewrite.
The patch with the workaround you mentioned (that BTW meanwhiles is
integrated in AOOo) has an explanation for the problem in vnew.cxx.
More information about the LibreOffice