[Libreoffice] WaE in chart2/source/controller/main/ShapeController.cxx
michael.meeks at novell.com
Mon Sep 26 01:22:43 PDT 2011
On Sun, 2011-09-25 at 11:08 -0500, Norbert Thiebaud wrote:
> I'm quite confused with
> that create a WaE due to pColor being un-used... but -- based on the
> 'before' code -- it feels like just removing the line may be wrong..
Right - my bad, I removed only most of the obsolete cruft; this
- if ( pColorItem && pColorItem->GetColorTable() == &XColorList::GetStdColorTable() )
was just some horrible-beyond words propagation of obscure lifecycle
implementation detail of that dialog into all the callers that is now
un-necessary. I just forgot to remove the pColorItem fetch which is now
also not needed; pushed that cleanup.
michael.meeks at suse.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice