[Libreoffice] ODBC handles, a quibble
michael.meeks at novell.com
Fri Sep 30 04:25:10 PDT 2011
First - it's awesome to have you looking at, reading and caring about
the ODBC code - that's brilliant.
On Thu, 2011-09-29 at 12:02 -0400, Terrence Enger wrote:
> Silly me! While reading some of the LibreOffice code for
> ODBC connections, I started to look at ...
> This passage in section "4.4.1 Handles" catches my eye:
> The validity of a handle in a compilation unit other
> than the one in which the identified resource was
> allocated is implementation-defined.
> Yikes! How can any large (or moderate sized) project avoid
> assuming the validity of ODBC handles across the boundaries
> of compilation units ?
Well - particularly since there is no possible work-around beyond
munging everything into one big beast of a C++ file ;-)
> LibreOffice seems to assume continued validity;
Sure - anything else would seem to imply a madness on the side of the
ODBC implementation author that would amount to perversity ;-) are these
methods really going (at run-time) to walk up the stack, find where the
caller came from, work out which object file it was and then do
'undefined' things if the next call on the handle comes from somewhere
> (*) What ODBC driver invalidates an ODBC handle across
> compilation unit boundaries?
I have no idea - but unless I totally misunderstood this I'd be amazed
if any did.
> (*) By what magic can the driver know anything about its
> caller's compilation units, anyway?
Quite ;-) I mean - "in the same DSO" might be feasibly detectable
> Will some kind soul here please tell me that I need not
> worry about such things?
Certainly - you don't need to worry about such things ;-) most of the
legacy bugs in the LibreOffice code are of the more startlingly obvious
kind (in my experience), and in the connectivity world often have a
helpful: // TODO - actually implement this ;-) next to them.
Does that help !
Out of interest which bug / feature are you chasing ? (and do you hang
out on IRC ? :-).
All the best,
michael.meeks at suse.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice