RTL_CONSTASCII_(U)STRINGPARAM officially obsolete

Dézsi Szabolcs dezsiszabi at hotmail.com
Thu Apr 5 01:47:42 PDT 2012


> > if (foo.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("XXXXX")))
> > if (foo.equals(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("XXXXX"))))
> >
> > can be written as
> >
> > if( foo == "XXXXX" )
> 
> This has to be the biggest improvement in OOo/LO codebase readability
> ever! Incredibly nice!
> 

Hi! Yesterday I started to replace all occurences of equalsAsciiL to ==. There are 1898 more :)
compiling sc gave me an error:

  szabolcs at linux-jfhj:~/core> make sc debug=true
  cd sc && make -j 2 -rs gb_PARTIALBUILD=T
  [ build CXX ] sc/source/core/data/column3.cxx
  [ build DEP ] LNK:Library/libsclo.so
  [ build LNK ] Library/libsclo.so
  /home/szabolcs/core/workdir/unxlngx6.pro/CxxObject/sc/source/core/data/column3.o: In function `void boost::checked_delete<ScNoteCell>(ScNoteCell*)':
  /home/szabolcs/core/solver/unxlngx6.pro/inc/boost/checked_delete.hpp:34: undefined reference to `ScNoteCell::~ScNoteCell()'
  collect2: ld returned 1 exit status
  make[1]: *** [/home/szabolcs/core/workdir/unxlngx6.pro/LinkTarget/Library/libsclo.so] Error 1
  make: *** [sc] Error 2

Is this error related to the changes I made? All other modules compiled just fine.

Szabolcs
 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120405/8b68a85f/attachment.htm>


More information about the LibreOffice mailing list