[REVIEW 3-5][PATCH] Re: librO python & ssl support

Caolán McNamara caolanm at redhat.com
Tue Apr 10 08:14:46 PDT 2012


On Fri, 2012-04-06 at 12:56 +0200, Laurent Godard wrote:
> i had a look and here is the patch i deduced. may be wrong as makefile 
> things are a bit cryptic to me ;)

Tweaked it a bit and seems to work here, I get the expected results from
ldd
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b773045fa0470776e37731d5bb9805bfb0cc4a7e

> i have a remaining question though (may be dummy) :
> 
> why in python_LDFLAGS do we use /usr/lib and not /usr$/lib as on other 
> lines. is it important ? does it make any difference ?

Probably an oversight, but the SYSBASE stuff is only in use on unix-like
platforms, and these days in practice only on android (I think), so I
moved your change before that block.

> as i told, in previous build i myself made, i had no problem

Yeah, cause if it links against your system openssl libs, then you'll
have those present and no problem.

Now proposing the above commit for 3-5.

C.



More information about the LibreOffice mailing list