[PATCH] fdo#45904: [EasyHack] move java based api tests to c++

Markus Mohrhard markus.mohrhard at googlemail.com
Tue Apr 17 03:53:24 PDT 2012


Hey Miklos,

> On Sun, Apr 15, 2012 at 03:16:35AM +0200, Artur Dorda <artur.dorda at gmail.com> wrote:
>> This patch is transferring XPrintAreas test to c++, from
>> qaDevOOo/tests/java/ifc/sheet to test/inc/test/ and test/source/
>
> Great!
>
>> Though not all tests are transferred, I'm sending this so it could be
>> reviewed, because it's my first patch and changes 5 files.
>
> Is there any reason why didn't remove the replaced java code from
> qadevOOo?
>

This was my decision. The qaDevOOo tests have no clean dependencies so
I prefer if we don't remove them and just disable the test in
knownissues.xcl or module.sce. As soon as no test from one module are
executed any more we can safely remove the corresponding directory in
qaDevOOo, otherwise we run into some strange runtime crashes.

Regards,
Markus

P.S. I will review the patch this evening.


More information about the LibreOffice mailing list