[PUSHED:3-5]patches for 35 MAB fdo#45376 already in master ..

Petr Mladek pmladek at suse.cz
Tue Apr 17 04:49:12 PDT 2012


Noel Power píše v Po 16. 04. 2012 v 10:18 +0100:
> On 16/04/12 09:49, Petr Mladek wrote:
> > Cor Nouws píše v Ne 15. 04. 2012 v 16:08 +0200:
> >> Hi,
> >>
> >> I see Bug 45376 - [FORMATTING] Incorrect text wrapping around drawing
> >> shape, one of the 3.5 MAB issues, that seems to be fixed with two
> >> commits in master, according to comment 4 (
> >> https://bugs.freedesktop.org/show_bug.cgi?id=45376#c4 )
> > It is about these two commits:
> >
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=b446a1fb30b5a7097824acfe6bbbb143f4284b03
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=84370b807279cd8336c3e77278bae42b904324b4
> >
> >> Could pls be considered to push these patches to 3.5 branch too?
> > Noel, you pushed them into master. Do you still remember them? Are they
> > safe for 3-5? It looks like to me :-)
> >
> ok I remember this, it was a problem ( to do with text wrapping around a 
> shape ) that only showed in the preview I think. The fix however was to 
> the (mystery) layout code and I am not sure if that code is specific to 
> the preview or not. At the time it didn't seem ( to me ) the problem was 
> serious enough to risk 3.5

Hmm, it is in most annoying bugs. Also the problem persists when you
close the print preview. The fix just clears a cache which should be
safe. I did some testing and it worked fine => pushed into 3-5

I squashed it into one commit, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=2d7ce65af37195343ff74b9e01c60f4b86eb6ebe

Best Regards,
Petr





More information about the LibreOffice mailing list