[PATCH] fdo#39643: Remove --disable-strip-solver configure option

Petr Mladek pmladek at suse.cz
Mon Apr 23 04:27:37 PDT 2012


Hi David,

thanks a lot for looking at it. Your patch is almost perfect. Well,
there are still some open questions, see below. :-)

David Ostrovsky píše v So 21. 04. 2012 v 14:23 +0200:
> Hi,
> 
> here is the patch to remove strip solver configure option.
> Some places still has a strip code, for example in solenv/bin/deliver.pl
> 
> sub initialize_strip {
>      if ((!defined $ENV{CROSS_COMPILING}) || ($ENV{CROSS_COMPILING} ne 
> 'YES')) {
>          $strip .= 'guw ' if ($^O eq 'cygwin');
> [...]
> 
> was not sure if it is still needed.

Please, remove strip from deliver.pl. Otherwise, the binaries will be
always stripped. We need non-stripped binaries when producing debuginfo
packages on Linux.

Hmm, we might want to keep the strip stuff and the -dontstrip options in
the in the perl installer. It is handy when you have debug build and you
need to send someone the small stripped build. It is a big difference in
the size. I am not sure if "make install" should strip by default or
not. Bjoern, Lubos, what do you think?


Best Regards,
Petr



More information about the LibreOffice mailing list