[PUSHED][PATCH] fdo#45664 EasyHack: Calc can't export the cells formulas to CSV (only the cells values)

[Eike Rathke]

Hi Florent,

On Monday, 2012-04-23 04:47:50 +0200, Florent Gallaire wrote:

> I think this patch is clean.

Hey, great, thanks!
It didn't apply cleanly as some of the surrounding code lines were
changed in the mean time, but pushed with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c041db6f59888adc90ee8257eafe150d874c46c9

> I hope Eike Rathke will agree.

Well, almost ;-)
For my nitpicks please see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3cceb8a900cd1fe1ae9bdb0c2e532e82a1835861

Main change is that the "Save cell content as shown" option is
independent of the "Save formulas" option and should not be disabled
when checking that. I also made the initial state depend on the "Show
formulas" view option.

As this seems to be your first contribution to the code base could you
please send a blanket statement to the mailing list (preferably in this
thread) that you contribute this and further patches under LGPLv3+ and
MPL 1.1 licenses? After having done so you may also want to add yourself
to https://wiki.documentfoundation.org/Development/Developers and in the
License column point to that mail in the archive.

Thanks for the patch, I hope we see more from you :-)

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120425/ced903e1/attachment.pgp>