[PUSHED] Re: [PATCH] EasyHack #32621 - More robust ExternalMailer support

Jan Holesovsky kendy at suse.cz
Mon Apr 30 06:57:58 PDT 2012


Hi Dave,

On 2012-04-27 at 19:34 +0200, Thorsten Behrens wrote:

> > Proposed patch attached to use the gnome-open/xdg-open URI handler,
> > with a mailto link, when the currently configured mailer is not
> > recognized.
> 
> hmm - can you elaborate a bit when that case happens?

So I guess that is for the case the user writes something broken into
the mailer setting, which results in non-working sending of email.

>  The code looks
> very much like the DESKTOP_LAUNCH part, and I thought that was
> ~standardized
> 
>  http://lists.freedesktop.org/archives/xdg/2004-August/002873.html
> 
> at least we can possibly fold the two branches together, by falling
> back to xdg/kde/gnome-open?

I am afraid it is not as standardized as we would love it to be ;-) -
though the configuration backends seem to do a reasonable job to setup
something usable there, at least in gnome / kde [at least for me].

Having said all this, I don't think it is a bad idea to try to be smart
a bit in the case the user has entered something invalid into the mail
client setting herself, and try to do the reasonable thing when
everything else fails anyway; so - pushed, thank you! :-)

http://cgit.freedesktop.org/libreoffice/core/commit/?id=77d4873ee653549eb8fb8761253f9feb1eea1c11

As this is (according to my incomplete mail archive) your first
contribution to LibreOffice - can you please send a license statement to
this mailing list stating that all your contributions to LibreOffice are
licensed under the MPL / LGPLv3+?

Thank you a lot,
Kendy



More information about the LibreOffice mailing list