[PATCH] convert table.hxx use in editeng/inc/editeng/forbiddencharacterstable.hxx

Noel Grandin noel at peralex.com
Wed Feb 15 07:01:31 PST 2012


Hi

Updated patch implementing Ivan's suggestion. Passes make and make check.

Convert tools/table.hxx usage in  
editeng/inc/editeng/forbiddencharacterstable.hxx to std::map

Contributed under LGPLv3+ / MPL 1.1 or later.
(And my license statement is on file in the wiki)

Regards, Noel.


On 2012-02-12 12:08, Ivan Timofeev wrote:
> Hi Noel,
>
> On 10.02.2012 10:56, Noel Grandin wrote:
>> Convert tools/table.hxx usage in
>> editeng/inc/editeng/forbiddencharacterstable.hxx to boost::ptr_map
>
> ForbiddenCharactersInfo is simple wrapper for ForbiddenCharacters. It 
> only adds the bTemporary flag. But bTemporary seems to be write-only, 
> i.e unused. So, I'd suggest to remove bTemporary & 
> ForbiddenCharactersInfo, and then convert to std::map<sal_uInt16, 
> ForbiddenCharacters>. What do you think?
>
> Best Regards,
> Ivan
>

Disclaimer: http://www.peralex.com/disclaimer.html


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: convert-forbiddencharacters-table-to-map.diff
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120215/5a67b249/attachment.asc>


More information about the LibreOffice mailing list