The new global -DHEADLESS should be "namespaced" surely?

Riccardo Magliocchetti riccardo.magliocchetti at gmail.com
Tue Feb 21 00:40:47 PST 2012


Hello,

Il 21/02/2012 09:27, Tor Lillqvist ha scritto:
> Do we really want to use a generic and potentially clash-prone word
> like HEADLESS? Isn't the normal software engineering practise to use
> some package-specific prefix for global C-level identifiers like this?
> We already have -DLIBO_WERROR to indicate when --enable-werror is in
> force, and -DLIBO_MERGELIBS for --enable-mergelibs. Thus I suggest
> using -DLIBO_HEADLESS for this instead.

Makes sense to me, will post a patch.

thanks

-- 
Riccardo Magliocchetti


More information about the LibreOffice mailing list