[REVIEW 3-5] frame duplication regressions fdo#40599 fdo#46482 plus fix anchor handling in SwXText::convertToTextFrame()

Michael Stahl mstahl at redhat.com
Thu Feb 23 03:01:11 PST 2012


On 20/02/12 10:47, Miklos Vajna wrote:
> Hi,
> 
> See
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=9592f56323de27f9e1d890ee6259a5f4f328cbd3
> 
> It's an issue in the Writer UNO API, so it affects at least docx and RTF
> import, an RTF reproducer is attached. If some importer already worked
> around this issue by inserting empty paragraphs between textframes, then
> the added code will become a NOP.

as extensively discussed on IRC i didn't like the way this patch deleted
a spuriously inserted SwFrmFmt which seemed a bit risky and decided to
investigate the root cause of that problem instead.

i've found 2 (relatively obscure, i actually found fdo#46482 myself)
regressions that have the same root cause which is a change in
SwDoc::CopyFlyInFlyImpl for OOo 3.2, and so i would propose to backport
all 3 patches together to libreoffice-3-5, the one by Miklos plus:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=23e52c207760c596cc2f841ef59f3100c110d591
http://cgit.freedesktop.org/libreoffice/core/commit/?id=91fab30f3b1617024ee2eadf3c7ad1ea84d7f6dd



More information about the LibreOffice mailing list