[REVIEW][3-5-1][3-4] nsplugin broken due to typo

Rene Engelhard rene at debian.org
Wed Feb 29 14:24:36 PST 2012


Hi,

The nsplugin is broken in 3.4.5 and 3.5.0 - we just discussed this on IRC:

22:58 <@_rene_> mmh, I think the nsplugin is broken
22:58 <@_rene_> in both 3.4.5 and 3.5.0
22:59 <@_rene_> opens a separate LO window with *startcenter* instead of the document
22:59 <@_rene_> no idea, but...
22:59 <@_rene_>             mxRemoteMSF->createInstance( ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ucb.SimpleFileAccessw")) ),
23:00 <@_rene_> looks fishy to me? shouldn't it just be com.sun.star.ucb.SimpleFileAccess?
23:01 -!- monsterzero [~monsterze at CPE5cd9985f2795-CM001bd7ad832c.cpe.net.cable.rogers.com] has joined #libreoffice-dev
23:02 -!- jtang613 [63e09c2f at gateway/web/freenode/ip.99.224.156.47] has joined #libreoffice-dev
23:02 < jtang613> Q: Why don't LO cli commands work when a gui LO instance is present?
23:03 <@sberg> _rene_, yep, 648589a0bd6c72b8b6b125644b43c6efad17ead1 typo
23:03 < IZBot> core - RTL patch - http://cgit.freedesktop.org/libreoffice/core/commit/?id=648589a0bd6c72b8b6b125644b43c6efad17ead1
[...]
23:04 <@_rene_> sberg: ok...
23:05 <@_rene_> sberg: I  think this sounds like a -3-4 and 3-5-1 fix...
23:05 <@_rene_> will test and mail to ml...
23:05 <@sberg> _rene_, you can already count in my sign-off
23:07 <@_rene_> ok, so already signed-off for 3.5 at least ;-) -3-4 needs also 3? or just 1 as -3-5?
23:07 <@sberg> no idea :(
23:08 <@_rene_> we'll see
23:09  * _rene_ commits to master and -3-5 for now and mail the ml
23:09 <@_rene_> (verified that it fixed the plugin)

Trivial fix:



More information about the LibreOffice mailing list