[Libreoffice] minor idl fixes

Tomas Hlavaty tom at logand.com
Thu Jan 5 00:38:42 PST 2012


Hi Stephan,

Stephan Bergmann <sbergman at redhat.com> writes:

> On 01/04/2012 11:09 PM, Tomas Hlavaty wrote:
>
>> diff --git a/offapi/com/sun/star/chart/XAxisSupplier.idl
>> b/offapi/com/sun/star/chart/XAxisSupplier.idl
>> ...
>
> Are you sure that this is right, using chart2 entities from within
> chart?  I always intuitively thought that chart2 was a second attempt,
> to replace chart.

I am not sure as I don't know what chart and chart2 are about but
currently this is broken.  The patch fixes the compilation issue.  Maybe
I should move the file to chart2 package instead?

>> diff --git a/jurt/com/sun/star/comp/loader/JavaLoaderFactory.java b/jurt/com/sun/star/comp/loader/JavaLoaderFactory.java
>> -    public java.lang.Object createInstance()
>> +    public com.sun.star.uno.XInterface createInstance()
>
> and
>
>> diff --git a/jurt/com/sun/star/comp/loader/JavaLoader.java b/jurt/com/sun/star/comp/loader/JavaLoader.java
>> -    public java.lang.Object activate( String implementationName,
>> +    public com.sun.star.uno.XInterface activate( String implementationName,
>
> UNO XInterface maps to Java Object, see
> <http://wiki.services.openoffice.org/wiki/Uno/Java/Specifications/Type_Mapping>. Also,
> signatures of these methods must not be changed to avoid backward
> incompatibility.

That's a good point.  Any idea why XInterface is not used in all cases?
Has it something to do with the fact that reference counting happens
behind the scene in Java?

Thank you,

Tomas


More information about the LibreOffice mailing list