[Libreoffice] [REVIEW][3-5-0] Fix pivot table's date and number grouping, take 2

Petr Mladek pmladek at suse.cz
Wed Jan 25 08:36:02 PST 2012


Kohei Yoshida píše v Út 24. 01. 2012 v 16:53 -0500:
> Again, this fixes
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=45067
> 
> Since we've already branched for 3.5.0, I'll need three sign-off's to
> get this piece into 3.5.0 final.  Reviews and sign-off will be
> appreciated.

Works well here. It correctly creates pivot table with dates and with
strings and allows to group them accordingly. The patch looks sensible
=> pushed to 3-5 branch, see 
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=6cc0bf1394ef9d6941d38a55a6155688a6f9bd43

We need two more reviews for 3-5-0 branch.


Best Regards,
Petr


PS: I attach another test file from Kohei that allows to test both types
(dates and strings) when creating the pivot table.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test-pivot.ods
Type: application/vnd.oasis.opendocument.spreadsheet
Size: 9588 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120125/f91d133a/attachment-0001.ods>


More information about the LibreOffice mailing list