[Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update
kohei.yoshida at suse.com
Thu Jan 26 13:03:56 PST 2012
I'd like to have
cherry-picked to 3-5 and preferably to 3-5-0 as well. IMO this is a
The change consists of two parts. The real bug is in the first part
(ScColumn::DeleteRange), where a note cell with live broadcaster would
silently get deleted, hence losing link to its listeners.
Then the second part is in ScDPOutput::Output(), where the old content
gets removed before writing out a new one. The thing is, this method
only gets called from ScDPObject::Output(), and that method already
deletes the old content which makes the removal code in ScDPOutput
unnecessary. So, when updating or refreshing the pivot table output,
calc was essentially deleting the range twice. This, plus the first bug
combined caused the reference chain to break, whose effected is
The second part is optional as long as we put the first part. But it's
just redundant and it's good to have it removed for cleanliness' sake.
Having said that, if someone is not so sure, we can just put the first
part in for 3.5.
Reviews and sign-off's appreciated.
Kohei Yoshida, LibreOffice hacker, Calc
More information about the LibreOffice