[Libreoffice] [REVIEW][3.5.0][3-5][3-4] fdo#38595 Calc cell borders lost in ODF import

[Eike Rathke]

Hi,

On Thursday, 2012-01-26 20:20:14 +0100, Eike Rathke wrote:

> It looks like it would be an improvement also for Calc if after both
> attributes were read set LineWidth to the sum of outer,inner,space to
> cope with omitted/different fo:border width.
> 
> However, there seem(s) to be some place(s) in the conversion to
> SvxBorderLine where the constellation of LineWidth vs. outer,inner,space
> is not taken into account. I didn't dig into yet, but it probably would
> be convenient to have a conversion ctor from BorderLine2 instead of
> letting every application figure that out..

Apparently there already is such a thing,
editeng/source/items/frmitems.cxx  SvxBoxItem::LineToSvxLine()  and the
SvxBorderLine::GuessLinesWidths() in editeng/source/items/borderline.cxx
used there seems to do, just that LineToSvxLine would have to be used at
places where appropriate ...

Also the local lcl_extractBorderLine() might come handy in situations
where one wants to extract a TableBorder2 from an Any that holds either
TableBorder2 or TableBorder.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120126/3bcaa7ae/attachment.pgp>