[Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits
sbergman at redhat.com
Mon Jan 30 07:55:51 PST 2012
On 01/30/2012 03:43 PM, Lionel Elie Mamane wrote:
> I attach here the "less invasive" variant originally meant for
My SQL knowledge is actually zero. For example, I have no idea where to
look to verify that for some SQL_ATTR_CURSOR_TYPE, say, SQLGetStmtAttr
expects to find a buffer of type SQLULEN to write into.
That said, looking at the less invasive patch, it appears to always
replace towards potentially larger types (sal_uInt32/SQLUINTEGER ->
SQLULEN), so should at least resolve any buffer overruns.
So you can count this in as a layman's "looks good, with fingers crossed."
More information about the LibreOffice