[Libreoffice] [REVIEWED] Fix reading .doc comments (fdo#45255)
michael.meeks at suse.com
Mon Jan 30 11:52:07 PST 2012
On Mon, 2012-01-30 at 19:22 +0100, Lubos Lunak wrote:
> The regression is caused by commit 8434a6966914547451489db6828b31ae86901186,
> which added size checks, but incorrectly - remainingSize() is called before
> the seek to the right position is done, which occassionally makes the code
> believe the file is corrupt.
> I don't actually know the format enough to be certain about the fix, but I
> expect it is quite clear from the logic of the thing, so I've committed as
> b5a73d4b2b283d3d1a57ac0f66b608998960a873 . Please review and backport.
Looks lovely to me; pushed to -3-5, Caolan are you happy for 3.5.0 ? we
had busted comment interop with .docx in 3.4 (so people used .doc) :-)
michael.meeks at suse.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice