[Libreoffice-commits] .: Branch 'feature/remote' - sd/Library_sd.mk sd/source

[David Tardon]

Hi,

On Tue, Jul 10, 2012 at 12:59:49PM +0100, Michael Meeks wrote:
> Hi David,
> 
> On Tue, 2012-07-10 at 08:16 +0200, David Tardon wrote:
> > >      -I$(WORKDIR)/SdiTarget/sd/sdi \
> > > +    $(shell pkg-config --cflags json-glib-1.0) \
> > 
> > Please do not call pkg-config from makefiles. That is what
> > configure is for.
> 
> 	This is on a branch; we're trying to get something working quickly -
> and it's unclear to me whether we'll continue to use json-glib in
> future.

Okay, then.

> Also:
> 
> 	grep pkg-config */*.mk

So avmedia/Library_avmediagst.mk and vcl/Library_vclplug_gen.mk _must_
be fixed. I was hoping that kind of stuff would not pass through gbuild
conversion. But that is no excuse for using it in new makefiles :-)

D.