[PUSHED] Re: [PATCH] Final stretch of converting SV_DECL_PTRARR to STL containers stage 2/3

Michael Stahl mstahl at redhat.com
Thu Jul 26 05:34:54 PDT 2012


On 23/07/12 09:31, Noel Grandin wrote:
> Hi
> 
> These patches convert various places from SV_DECL_PTRARR to STL containers.
> 
> They have passed a full make check.

thanks, pushed to master.

#9 converts the unsorted  SwSelBoxes_SAR base class of the sorted
SvArray also to sorted_vector, which is wrong

patch #15 has a dereference of iterator not cheeked for end()

the ScHTMLColOffset and SvxTabStopArr have 2 actual non-const member
accesses; the ScHTML one looks entirely safe, i don't know about the RTF
tabstop one; i currently think that using const_cast in these very few
cases is better than exposing non-const accessors in sorted_vector for
everyone.



More information about the LibreOffice mailing list